tr7zw / ItemSwapper

Tweaks to the inventory system based on Xisumavoid's video.
Other
101 stars 30 forks source link

Fix translations #88

Closed RedVortexDev closed 1 year ago

RedVortexDev commented 1 year ago

Formatting JSON, fixing a translation not having a JSON format and adding a comma, no changes to actual translation, but just making it actually work lol

RedVortexDev commented 1 year ago

Note that I formatted based on 4 spaces like found in the mod's java source code

tr7zw commented 1 year ago

Hm, these are badly formatted too? Using tabs instead of spaces.

tr7zw commented 1 year ago

I use VSCodes (built in?) formatter, that matches the formatting I also use for java code.

RedVortexDev commented 1 year ago

Go to a java file, what do you see in the bottom right? It should tell you how you indent (tabs/spaces: num)

tr7zw commented 1 year ago

It's the normal 2 spaces instead of tabs. The lang file was probably copied from another project and not formatted, that's why it had 4 spaces. In the end I don't really care, but tabs are a bit of a nope.

RedVortexDev commented 1 year ago

well I used spaces so is that alr

tr7zw commented 1 year ago

grafik The pr is using tabs.

RedVortexDev commented 1 year ago

My bad, fixed

RedVortexDev commented 1 year ago

Oof, i used 4 spaces

RedVortexDev commented 1 year ago

now it should be fixed