tr7zw / NotEnoughAnimations

Brings the First-Person animations to the Third-Person and tries to fix other animation issues of the Third-Person.
Other
89 stars 21 forks source link

Suggestion: better attack animations for enhanced experience with first person model #152

Open lumagatto opened 1 year ago

lumagatto commented 1 year ago

-Body should rotate slightly to the left, to increase the right arm's reach and so increase visual credibility of the attack -Time from swing to rest position should depend on attack speed, so that attack cooldown is directly visible

tr7zw commented 1 year ago

I'm not really looking into changing vanilla animations like that with this mod(same with walking/running/jumping etc). Depending on your setup, adding a mod like BetterCombat might fit better?

TheRealPicasso commented 1 year ago

I'm not really looking into changing vanilla animations like that with this mod(same with walking/running/jumping etc). Depending on your setup, adding a mod like BetterCombat might fit better?

bettercombat changes Vanilla tho, there is no current mod that changes fight animations, without changing the speed etc

tr7zw commented 1 year ago

I can swing in, recently tested using the "new" 1.19 animation system(used by like frogs, Warden, camel, etc) on the player, and making the animations in Blockbench(instead of pure code, like vanilla/this mod currently do). This seems to work well, so the plan would be to make an addon to this mod, which contains the more "out there" animations, and replacing animations like walking/jumping/sprinting/hitting. Probably would need 1-2 people that can create some decent stuff in Blockbench.

TheRealPicasso commented 1 year ago

I can swing in, recently tested using the "new" 1.19 animation system(used by like frogs, Warden, camel, etc) on the player, and making the animations in Blockbench(instead of pure code, like vanilla/this mod currently do). This seems to work well, so the plan would be to make an addon to this mod, which contains the more "out there" animations, and replacing animations like walking/jumping/sprinting/hitting. Probably would need 1-2 people that can create some decent stuff in Blockbench.

YOOO this sounds amazing dude, get upvotes on discord or anything for this

tr7zw commented 1 year ago

I mean, so far I've written a proof of concept "blockbench -> player" conversion logic. Don't have anything done at this point, just some "I took 1 minute to learn how to do animations in Blockbench" animations. Would either take some time to get decent at it or someone else that has some good animations/ability to create some nice animations. testanimation

https://github.com/tr7zw/NotEnoughAnimations/assets/5133936/493381b2-fff3-4736-979f-f05b6b73ee7f

TheRealPicasso commented 1 year ago

I mean, so far I've written a proof of concept "blockbench -> player" conversion logic. Don't have anything done at this point, just some "I took 1 minute to learn how to do animations in Blockbench" animations. Would either take some time to get decent at it or someone else that has some good animations/ability to create some nice animations. testanimation

q66p5zlWrb.mp4

everything has a start! Animations arent easy to make sadly... Do you think its possible to make such smooth animations like in the minecraft trailer? (bending arms and legs a little etc.) and curve speed for different components? But im glad finally someone has started this. There are way to less animation mods outthere, which can make the game feel so much smoother

tr7zw commented 1 year ago

I mean, bending arms/legs is something I'd still not touch. That would require modifying the model and that sounds like a horrible pain in the ass(see Mo'Bends). And I mean, this would be somewhat inspired by Trainguys Animation Overhaul mod, but he sadly doesn't have the time to update the mod/release for new versions.

TheRealPicasso commented 1 year ago

Sadly none of those are made for the new versions yea, but i get your point, it's pretty costly to modify a model... Well i still think its nice to enhance mods!

tr7zw commented 1 year ago

So far I kicked bending moddels and more dynamic animations down the road, now planning to do dynamic animations, so maybe a few months/years down the line 😅

TheRealPicasso commented 1 year ago

Oh sounds pretty good! Btw do you have a discord tag/server? I would like to support you and stay tuned :)

Edited: found your server already, btw are you German? (I am)

tr7zw commented 1 year ago

btw are you German?

yep

TheRealPicasso commented 1 year ago

How is it going? Did you continue it? :o

tr7zw commented 1 year ago

Currently really busy irl(renovating, bachelor thesis, buying essentials to move in, working, trying to find a new job), so the mods are a bit on the backburner for now. The main issue with that idea currently is, that I suck at creating animations 😅

TheRealPicasso commented 1 year ago

Currently really busy irl(renovating, bachelor thesis, buying essentials to move in, working, trying to find a new job), so the mods are a bit on the backburner for now. The main issue with that idea currently is, that I suck at creating animations 😅

oh man its alright, dont stress out, reallife is more important, hope you will get everything!

lumagatto commented 10 months ago

Hello! How is this going?

tr7zw commented 10 months ago

Same state as my last message, just that I moved.