search

tr7zw / NotEnoughAnimations

Brings the First-Person animations to the Third-Person and tries to fix other animation issues of the Third-Person.
Other
92 stars 24 forks source link

[1.21] Sneaking on ladder doesn't prevent cape from shifting. #198

Open Ampflower opened 3 months ago

Ampflower commented 3 months ago

With quick code analysis, it seems that the CapeFeatureRenderer uses abstractCleintPlayerEntity.isInSneakingPose() rather than the model's sneaking field.

Likely a fairly simple redirect.

Have yet tested with an elytra.

Ampflower commented 3 months ago

Evidently, that was for the angle of the cape, not the Y positioning; although it does make the cape less visually awkward.

Ampflower commented 3 months ago

Come to realise it; the LadderAnimation does not seem to be properly applying a pose overwrite on 1.21, although it seems capable of overwriting the model's sneaking overwrite fine.

tr7zw commented 3 months ago

Will have to look into it. Tbh had 0 time so far to play 1.21 myself.