tr7zw / PaperDoll

Shows a Bedrock/PocketEdition like highly configurable PaperDoll.
Other
12 stars 5 forks source link

[BUG] Paperdoll+cosmetica crash #16

Closed DanMeadWasTaken closed 1 year ago

DanMeadWasTaken commented 1 year ago

When joining a world/server, it simply crashes the whole client- seems to be a conflict between cosmetica cosmetics rendering and the paper doll rendering. for context i was using some of the cosmetics- so it could be how the cosmetics are being rendered including the fact that one of them hovers over the shoulder?

crash link given by notenoughcrashes (yes i know it's not recommended to use it, but the ability to not fully crash helps me to find the issue faster- so i only run it when i run into an issue)

https://bytebin.lucko.me/1C8w7Bq3LC

and the full log supplied by prism launcher

https://mclo.gs/6GpSema

tr7zw commented 1 year ago

Somehow EntityRenderDispatcher.getSquaredDistanceToCamera crashes due to the camera being null, when cosmetica tries to get the distance... Honestly, no clue, since it also seems to try to render a nametag during the paperdoll rendering?!? Best-case open an issue on cosmeticas end instead.

For context: this uses the same logic as the player seen inside the inventory, and neither nametags nor camera is touched there by this mod, so the logic issue happens on their end.

Volcan4436 commented 1 year ago

Hmm interesting don't know why that broke tbh my Cheat Client I develop has a paper doll and it's fine and it shows the Cosmetica cosmetics and Nametag can you send your mod your using

Volcan4436 commented 1 year ago

I just checked the mod I will take a look at my source code to see if it is the same and if so I can probably fix the mod for you

DanMeadWasTaken commented 1 year ago

As the issue seems to either have fixed itself or been fixed, i'll be closing this- basically, one way or another, it stopped crashing