tr7zw / WaveyCapes

The cape shouldn't be a static slab
Other
90 stars 19 forks source link

[ Suggestion ] WavyElytra #22

Open SzczurekYT opened 2 years ago

SzczurekYT commented 2 years ago

Hello I really like your mod I I tought that adding this same functionality for elytra would be could. Just imagine the waving wings. They also aren't static slab. What do you think about that? If you would approve that maybe I could try to make this work and open PR?

tr7zw commented 2 years ago

grafik I guess this answers it. I have thought about it, but it's a bit tricky(especially in the scope I am/was planning). My idea was to split the wings into parts, keep the outer edge at the vanilla fixed location, but let the inner edge be simulated. This has a "few" challenges:

But yea, if you have the experience to work on points of this, be my guest(here on Github/Discord).

tr7zw commented 2 years ago

Basically animated it in a style how the bone part outside is static(where the elytra have the thick edge), but animated on the thin inner part.

SzczurekYT commented 2 years ago

Cool idea, but for me it also seems complicated, I think that you are more experianced than me. Also I'm not sure if minecraft elytra is big enough to make this effect you are proposing visible. For me cape's physic applied to elytra would be enough.

tr7zw commented 2 years ago

Just blindly applying the cape physics would look really odd when it's just flopping around you while you are "gliding" with it.

SzczurekYT commented 2 years ago

Yeah, some isGliding check would fix that.

tr7zw commented 2 years ago

I mean to have it when not gliding is like 90% of the way there. So might as well add slight waves to it then.

SzczurekYT commented 2 years ago

Exactly, the gliding part is less important because it looks fine in vanilla. With this mod it's just so odd for me that when I walk elytra has no movement.

tr7zw commented 2 years ago

What I meant with that is, when you can move and animate it while walking, then you might as well also animate it while flying. The issue is getting to this point at all.

SzczurekYT commented 2 years ago

Ah ok

Aces-and-Jacks commented 1 year ago

Unsure about how far you are with this, but as a temporary solution you could do something similar to this https://www.curseforge.com/minecraft/mc-mods/elytra-physics

Only a suggestion tho, if you don't want to do it that's fine as well

tr7zw commented 1 year ago

That actually looks like a nice solution for when walking. I had more in flight/ or start/stop of flight in mind. The recently added Simulation V2, which runs in 3d internally, might help with this. Still would require redoing the entire elytra model to be animate-able.

DelofJ commented 1 year ago

So you would let the animation when walking part to Elytra Physics and you do the flying animation part ?

Aces-and-Jacks commented 10 months ago

I'm guessing this is still on pause