Closed anko9801 closed 3 weeks ago
⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪ |
🧪 No relevant tests |
🔒 No security concerns identified |
⚡ Key issues to review Tailwind CSS Migration Tailwind CSSクラスの適用が正しく行われているか確認が必要です。特に、新しいクラス名が既存のスタイルと競合しないか検証する必要があります。 Width Consistency `w-72`への変更が適切かどうか確認してください。以前の`w-70`からの変更が意図した通りのビジュアル変更を引き起こしているかレビューが必要です。 |
/review
/improve
Category | Suggestion | Score |
Possible bug |
___
** | 9 |
Enhancement |
Tailwind CSSのグループ化されたクラスを正しく使用するために修正します。___ **
| 7 |
Persistent review updated to latest commit https://github.com/traPtitech/Jomon-UI/commit/1506e22b1bf710aa0272a58229e76fecd07e85de
LGTMです 一応Code Suggestionsを見ていただきたいのと、僕だとわからないことも多いのでめふもさんにもレビューをお願いしたいかもです
User description
fix: #139
PR Type
enhancement, dependencies
Description
vite.config.ts
からWindiCSSプラグインを削除しました。tailwind.config.js
を追加し、カスタムカラーとタイポグラフィプラグインを定義しました。postcss.config.js
を追加し、Tailwind CSSとautoprefixerを設定しました。package.json
を更新し、Tailwind CSS関連の依存関係を追加し、WindiCSS関連の依存関係を削除しました。Changes walkthrough 📝
20 files
TransactionFilters.vue
Migrate TransactionFilters to Tailwind CSS
src/components/transactions/TransactionFilters.vue
TransactionItem.vue
Migrate TransactionItem to Tailwind CSS
src/components/transactions/TransactionItem.vue
PaginationBar.vue
Update PaginationBar with Tailwind CSS
src/components/shared/PaginationBar.vue - Adjusted width classes for pagination buttons.
GroupsPage.vue
Apply Tailwind CSS to GroupsPage
src/pages/GroupsPage.vue - Updated minimum width using Tailwind CSS.
TransactionsPage.vue
Apply Tailwind CSS to TransactionsPage
src/pages/TransactionsPage.vue - Updated minimum width using Tailwind CSS.
RequestsPage.vue
Apply Tailwind CSS to RequestsPage
src/pages/RequestsPage.vue - Updated minimum width using Tailwind CSS.
InputSelectMultiple.vue
Update InputSelectMultiple with Tailwind CSS
src/components/shared/InputSelectMultiple.vue - Adjusted width calculation for input select.
RequestFilters.vue
Update RequestFilters with Tailwind CSS
src/components/requests/RequestFilters.vue - Adjusted margin-left for span elements.
InputSelectSingle.vue
Update InputSelectSingle with Tailwind CSS
src/components/shared/InputSelectSingle.vue - Adjusted width calculation for input select.
NewTransactionPage.vue
Apply Tailwind CSS to NewTransactionPage
src/pages/NewTransactionPage.vue - Updated minimum width using Tailwind CSS.
AdminPage.vue
Apply Tailwind CSS to AdminPage
src/pages/AdminPage.vue - Updated minimum width using Tailwind CSS.
RequestDetailPage.vue
Update RequestDetailPage with Tailwind CSS
src/pages/RequestDetailPage.vue - Adjusted height for div using Tailwind CSS.
NewRequestPage.vue
Apply Tailwind CSS to NewRequestPage
src/pages/NewRequestPage.vue - Updated minimum width using Tailwind CSS.
NewGroupPage.vue
Apply Tailwind CSS to NewGroupPage
src/pages/NewGroupPage.vue - Updated minimum width using Tailwind CSS.
RequestContent.vue
Update RequestContent with Tailwind CSS
src/components/requestDetail/RequestContent.vue - Adjusted margin-left for div using Tailwind CSS.
CommentLog.vue
Update CommentLog with Tailwind CSS
src/components/requestDetail/CommentLog.vue - Adjusted margin-left for div using Tailwind CSS.
PageLink.vue
Simplify PageLink component
src/components/shared/PageLink.vue - Removed block class from router-link.
tailwind.config.js
Add Tailwind CSS configuration
tailwind.config.js
postcss.config.js
Add PostCSS configuration for Tailwind CSS
postcss.config.js - Added PostCSS configuration with Tailwind CSS and autoprefixer.
main.css
Integrate Tailwind CSS into main styles
src/styles/main.css - Added Tailwind CSS base, components, and utilities.
3 files
vite.config.ts
Remove WindiCSS from Vite configuration
vite.config.ts - Removed WindiCSS plugin.
mockServiceWorker.js
Update MSW version in mockServiceWorker
public/mockServiceWorker.js - Updated MSW package version.
package.json
Update package.json for Tailwind CSS migration
package.json
1 files
package-lock.json
...
package-lock.json ...