search

traPtitech / traPortfolio

部員の活動紹介サービス traPortfolio
https://portfolio.trap.jp
7 stars 0 forks source link

:recycle: Move injector #652

Closed H1rono closed 3 months ago

H1rono commented 5 months ago

close #608

ras0q commented 5 months ago

main.goごと移動させていいと思ったけどpackageがmainになっちゃうのか

H1rono commented 5 months ago

はい あと、go.modと同じ場所にmainがないといけないっぽい？

H1rono commented 5 months ago

rebased.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.34%. Comparing base (e0b1129) to head (4525f42).

Files Patch % Lines
injector.go 0.00% 1 Missing :warning:
main.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #652 +/- ## ======================================= Coverage 61.34% 61.34% ======================================= Files 54 54 Lines 4312 4312 ======================================= Hits 2645 2645 Misses 1606 1606 Partials 61 61 ``` | [Flag](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/652/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `61.34% <0.00%> (ø)` | | | [unit](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/652/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `61.34% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ras0q commented 4 months ago

はい あと、go.modと同じ場所にmainがないといけないっぽい？

手元で試したけど多分このはずはないので本番と結合テストでinjectorを分けたらmain.goも移行できそう

H1rono commented 4 months ago
H1rono commented 3 months ago

injectとは・意味・使い方・読み方・例文 - 英ナビ!辞書 英和辞典

inject A into B: AをBに注入する

なのでinjectAPIIntoServerとか？injectAPIToServerでも

H1rono commented 3 months ago

あーAPIが二重の意味持ってるのか injectToAPIServerだな

H1rono commented 3 months ago

大した変更してないけど