traPtitech / traPortfolio

部員の活動紹介サービス traPortfolio
https://portfolio.trap.jp
7 stars 0 forks source link

oapi-codegenの参照先URLを変更 #704

Closed Pugma closed 4 months ago

Pugma commented 4 months ago

make go-genを実行したらoapi-codegenの参照URLが変更されていることが分かったので、それに対応しておきました

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.56%. Comparing base (f5a63a4) to head (2816460).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #704 +/- ## ========================================== + Coverage 73.13% 73.56% +0.42% ========================================== Files 54 54 Lines 4218 4218 ========================================== + Hits 3085 3103 +18 + Misses 982 963 -19 - Partials 151 152 +1 ``` | [Flag](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `73.56% <ø> (+0.42%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `73.56% <ø> (+0.42%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ras0q commented 4 months ago

これリダイレクトされないのか

issueにも情報ないんですが確かどこかのアップデートで一部スキーマの変更があったような記憶があるのですが、変更後の状態でmake go-genすると変更でますか? https://github.com/traPtitech/traPortfolio/issues/691

Pugma commented 4 months ago

いや、特に変更でないです 自動生成済みのファイルってgitの参照に入ってましたよね、確か

ras0q commented 4 months ago

や嘘、ここも変わらない? https://github.com/traPtitech/traPortfolio/blob/f5a63a47fe577f79a458bef82de13b371776e6f5/interfaces/handler/schema/schema_gen.go#L3

Pugma commented 4 months ago

中身が変わってなさそうなので大丈夫かなって判断しちゃいました

ras0q commented 4 months ago

なるほど、そこもpushしてくれたらmergeしてokです!

ras0q commented 4 months ago

あ最初からpushしてくれてた🙌