traPtitech / traPortfolio

部員の活動紹介サービス traPortfolio
https://portfolio.trap.jp
7 stars 0 forks source link

パッケージ構成の変更 #705

Closed ras0q closed 2 months ago

ras0q commented 2 months ago

プロジェクト内の一連の処理をinternalパッケージ以下にまとめた util->pkgs,interfaces/handler->handlerなどの変更も入れている util(pkgs)はinternalの外に出してもいいがtraPortfolio以外のパッケージから使われることもないのでinternal以下に置いた

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.46%. Comparing base (b0977ea) to head (d5e27ce).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #705 +/- ## ========================================== + Coverage 73.49% 74.46% +0.97% ========================================== Files 54 52 -2 Lines 4218 4163 -55 ========================================== Hits 3100 3100 + Misses 965 910 -55 Partials 153 153 ``` | [Flag](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/705/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/705/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `74.46% <ø> (+0.97%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/705/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `74.46% <ø> (+0.97%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ras0q commented 2 months ago

分けてるのをよく見るくらいの理由しか出せないな、、

https://github.com/moby/moby https://github.com/googleapis/google-api-go-client

ras0q commented 2 months ago

利点としてはgo test ./internalとgo test ./integration_testsでテストの実行を分けられるとかがある (internalの中に入れると変更前のようにgo listをごにょごにょする必要がある)

ras0q commented 2 months ago

とりあえずマージ