traPtitech / traPortfolio

部員の活動紹介サービス traPortfolio
https://portfolio.trap.jp
7 stars 0 forks source link

プロジェクト名とコンテスト名の重複を禁止して、名前の上限を伸ばした #723

Closed Tennessine699 closed 2 months ago

Tennessine699 commented 2 months ago

resolves #703 resolves #712

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 27.88462% with 75 lines in your changes missing coverage. Please review.

Project coverage is 72.88%. Comparing base (49b4548) to head (0f5ef59). Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
internal/infrastructure/migration/v2.go 4.05% 70 Missing and 1 partial :warning:
internal/infrastructure/repository/contest_impl.go 80.00% 1 Missing and 1 partial :warning:
internal/infrastructure/repository/project_impl.go 80.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #723 +/- ## ========================================== + Coverage 72.51% 72.88% +0.37% ========================================== Files 42 42 Lines 3842 3843 +1 ========================================== + Hits 2786 2801 +15 + Misses 903 886 -17 - Partials 153 156 +3 ``` | [Flag](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/723/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/723/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `72.88% <27.88%> (+0.37%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/traPtitech/traPortfolio/pull/723/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech) | `72.88% <27.88%> (+0.37%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traPtitech#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ras0q commented 2 months ago

projectの方に投げたreviewはcontestも同様