search

trabian / hylomorph

A component library for redux-form
MIT License
0 stars 0 forks source link

Coding standards enforcement #6

Open jimmyhmiller opened 7 years ago

jimmyhmiller commented 7 years ago

Generally for new projects we are going with create-react-apps eslint rules. These are rather lax rules. Would it make sense to keep those or have something more strict. For example, should we enforce proptypes? Should we use flow?

jimmyhmiller commented 7 years ago

I think proptypes enforcement would be really good. I don't want stylistic issues enforce until we have a problem with them. Flow is cool, but I don't know if I'd want to introduce it in this project.

trabianmatt commented 7 years ago

Proptypes would probably provide the best feedback for users of the library (including ourselves). I'm also curious whether a styleguide generator might be able to make good use of that information.

For stylistic consistency I'd suggest trying out prettier. It may not be 100% how you would do it if you were formatting it yourself but it's solid.

trabianmatt commented 7 years ago

Apparently React itself is looking at using prettier. I bring it up not as an appeal to authority but because there's value in seeing similar formatting between your code and the code in the libraries you use.