xilinx.cpp: After programming, go to bypass, PR for #436

trabucayre / openFPGALoader

Universal utility for programming FPGA

https://trabucayre.github.io/openFPGALoader/

Apache License 2.0

1.22k stars 263 forks source link

xilinx.cpp: After programming, go to bypass, PR for #436 #440

Closed UweBonnes closed 8 months ago

UweBonnes commented 8 months ago

Needed for xc7s50 on VMM3 boards to detect FLASH.

trabucayre commented 8 months ago

LGTM, just a small question: An oneshot BYPASS read is enough? Not required to poll until DONE is high?

Thanks!

UweBonnes commented 8 months ago

I first has a loop waiting for DONE and a counter for the loop. The loop was only executed once, so I removed the loop and still flash was recognized. Removing the BYPASS instruction resulted again in a fail to recognize the flash.

trabucayre commented 8 months ago

Applied Thanks @UweBonnes !