search

trac-hacks / trac-mentions

@mentions plug-in for Trac
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Don't parse ticket description on every comment #7

Open toebu opened 9 years ago

toebu commented 9 years ago

It seems like the main ticket description is parsed for @mentions on every comment. This means if the ticket description contains "@dude" the "dude" will be added as a CC every time someone comments, event if the comment doesn't mention the dude at all. It should only parse the ticket description on creation of the ticket.

rjollos commented 9 years ago

You'll also want to parse the description when it is edited.

toebu commented 9 years ago

Not sure if that's the best thing to do. Maybe you were mentioned when the ticket was created, then you removed yourself from the CC. If now someone changes a little detail in the description, it would be annoying to get added to the CC again.

rjollos commented 7 years ago

Consider using ITicketChangeListener and sending a notification rather than manipulating the CC list. See TracMention for an example.