search

trac-hacks / tracstats

Project and source code statistics plugin for Trac.
http://trac-hacks.org/wiki/TracStatsPlugin
Other
20 stars 13 forks source link

Internal Error on Code Pane (table tmp_revision already exists) #2

Closed kofalt closed 14 years ago

kofalt commented 14 years ago

Similar to issue #1 I just created, the code link worked for at least one view and then failed with: OperationalError: table tmp_revision already exists

Trace: File "C:\Python25\Lib\site-packages\Trac-0.11.5-py2.5-win32.egg\trac\web\main.py", line 444, in _dispatch_request dispatcher.dispatch(req) File "C:\Python25\Lib\site-packages\Trac-0.11.5-py2.5-win32.egg\trac\web\main.py", line 205, in dispatch resp = chosen_handler.process_request(req) File "build\bdist.win32\egg\tracstats\web_ui.py", line 105, in process_requestFile "build\bdist.win32\egg\tracstats\web_ui.py", line 246, in _process_codeFile "C:\Python25\Lib\site-packages\Trac-0.11.5-py2.5-win32.egg\trac\db\util.py", line 60, in execute return self.cursor.execute(sql) File "C:\Python25\Lib\site-packages\Trac-0.11.5-py2.5-win32.egg\trac\db\sqlite_backend.py", line 58, in execute args or []) File "C:\Python25\Lib\site-packages\Trac-0.11.5-py2.5-win32.egg\trac\db\sqlite_backend.py", line 50, in _rollback_on_error return function(self, _args, *_kwargs)

System Information: User Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3 Trac: 0.11.5 Python: 2.5.4 (r254:67916, Dec 23 2008, 15:10:54) [MSC v.1310 32 bit (Intel)] setuptools: 0.6c9 SQLite: 3.3.4 pysqlite: 2.3.2 Genshi: 0.6dev-r0 mod_python: 3.3.1 Pygments: 1.2.2 Subversion: 1.6.4 (r38063) jQuery: 1.4.2

As I mentioned in the other ticket, we do use a custom field for our ticket (a radio option), but otherwise it is a very vanilla install.

kofalt commented 14 years ago

I think I know why this breaks: every time I restart my webserver, the Code pane loads correctly ONCE. After refreshing it will always be broken. The fact that it's complaining about "table tmp_revision already exists" probably means it's not clearing some temporary table?

mrjbq7 commented 14 years ago

I changed how it uses the DB-API, and it might be fixed now. Could you try again?

kofalt commented 14 years ago

Latest source fixed the Code view breaking and now loads correctly, though it seems to take about twice as long to load as the other pages. That may just be because it has to do more work, however (I see a lot of data being displayed).

mrjbq7 commented 14 years ago

Yeah, the Code view needs some performance work. On my 75,000 revision repository it took like 15 seconds to load. It could be sped up and is on my list.

kofalt commented 14 years ago

Sounds good. Closing ticket, will open issue for performance.