Add device and positions to app

[wpearse]

In this PR, new features:

• Show device info (from map tap "Devices", then a device name)
• Show devices as pins on the map (polls API only when you open the map screen)
• "Zoom-to-all" devices, with padding around the edge of map
• Web sockets to push Position updates to the app
• Data formatting of latlon (5 dp), speed (1dp) with units, course (compass direction, degrees)

Known issues:

• Zoom to all devices doesn't add padding around the edge of the map
• Some device/position info isn't shown (e.g. attributes, is valid, is outdated)
• If the API is polled while you have a callout visible, the callout is closed
• Web sockets don't work on my Traccar server (503)

[wpearse]

[tananaev]

I will try later and see if WebSocket connection works for me.

[tananaev]

I have figured out the problem with websocket. The cookie is set for /api path, so you need to request cookie for http://demo.traccar.org/api instead of top level http://demo.traccar.org/.

Please check login screen layout on iPhone 4S screen. It doesn't work properly. There must be some auto-layout issue.

[wpearse]

You were correct about the cookie path. This PR is ready for review now.

Positions are pushed to the app using the web socket, but the map only redraws all the positions every 10s on a timer. I did this because I wasn't sure what would happen if a massive amount of positions were pushed to the app quickly and repeatedly -- I wondered if maybe the app would lock up/freeze.

[tananaev]

It doesn't sound right. The map should be updated in real time. That was the whole point of using WebSockets. Why does map re-draw on every update? You just need to add/update single marker.

[wpearse]

OK. Just pushed a change to remove the timer, and update the map as soon as new positions are received from the web socket.

Only single markers are updated (only the ones that change), not all markers.

[tananaev]

OK, I'll try to find time to review it later today.

Does it mean we can publish the app after the merge is done? Is anything missing?

[wpearse]

For me personally, the only major thing I feel I need "right now" is to add the ability to change the map type (between: roads, roads + satellite imagery, and just satellite imagery).

I would also like some guidance about how the app should look/feel. I've built the UI in the app in what I think is a tidy way, but I have only used Traccar for a few weeks... you will have a much better idea about how things should work.

[tananaev]

Changing map type can wait. It's not that important for the first version. Let me review the code and the app, merge PR, and submit the app for Apple review if everything is fine. After that we can start on other features.

[tananaev]

Issues I found so far:

1. You need to support HTTPS version of WebSocket. As far as I remember, you don't need to change schema to ws or wss. Just use regular http schema.
2. App crashes on self.lastUpdate = dateFormatter.dateFromString(value as! String). I'm not able to see variables in debug mode for some reason, but I guess the issue is with date format. Make sure you are using latest version of Traccar server for testing.

Trying to fix my debug issues at the moment. Not sure why it doesn't show any variable values.

[tananaev]

Are you sure you are using Carthage dependencies correctly? I have another project and it looks completely different. I'm not a huge expert in iOS, so please correct me if I'm talking nonsense.

In my other project:

1. Dependencies in project navigator show as suitcases (frameworks).
2. I don't have anything in embedded binaries.
3. There is an extra build phase to copy frameworks.

In Traccar Manager project:

1. Dependencies in project navigator show with blue icons (sub-projects?)
2. Libraries are in embedded binaries section.
3. Extra build phase in missing

I was thinking my debugging issues are somehow related to dependencies. Does debugging work for you?

[wpearse]

By debugging you mean the symbol inspector? It works most of the time for me -- on this and other projects. When it doesn't work I assume it is just another Xcode bug :)

I've just pushed changes to:

• Use Carthage's built frameworks, instead of sub-projects. I would be curious to see if this fixes your debug problems.
• Use the same URL scheme as the API for the web sockets (http/https)
• Handle the case where we don't have timestamps to parse
• Round the course bearing to 1 dp (I wonder if nearest whole number is better)
• Reconnect web socket when the app is opened, if the user is still logged-in

[tananaev]

Thanks. I'll try it in the evening.

[tananaev]

Can you please fix the warning:

.../TraccarManager/LoginViewController.swift:48:17: 'UIAlertView' was deprecated in iOS 9.0: UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead

[tananaev]

Everything else looks good. I think we can merge and publish it. What's the minimum iOS we can target? iOS 8?

[wpearse]

Fixed that warning. Did your debug issues go away with those Carthage changes?

I've only tested on iOS 8 and above, so I wouldn't feel comfortable targeting anything lower.

I was playing with the app on the iPads today, and it might be nice to tweak so the app feels a bit more "at home" on the iPad. But for now, I think it is OK.

[tananaev]

Merged. I'll try to find time tomorrow to submit the app for Apple review.

[tananaev]

By the way, do you want me to include you as an author in the README file and license headers? If yes, do you want to add your email address there as well?

[wpearse]

That'd be awesome. Yes please -- "Will Pearse" and w.pearse@gmail.com. Thanks!