traccar / traccar-web

Traccar GPS Tracking System
https://www.traccar.org
Apache License 2.0
787 stars 1.09k forks source link

Add camper device category #1195

Closed TheZoker closed 7 months ago

TheZoker commented 7 months ago

This PR adds a new device category called Camper.

Screenshot of a tracker with that category: image

TheZoker commented 7 months ago

The source is here: https://www.iconpacks.net/free-icon/camper-van-13375.html

It is not required credit the author: image

I removed the translations

tananaev commented 7 months ago

Can you please provide a screen shot of the map with another category next to is, so we can compare.

TheZoker commented 7 months ago

Here are three in a row:

image

tananaev commented 7 months ago

It doesn't look very consistent with the style. Some very small details. And wheels are in different style.

TheZoker commented 7 months ago

Alright I will look for a different file. Where do the original icons come from? Maybe that will help to find something.

It needs to be a icon without credit, right?

tananaev commented 7 months ago

Yes, it needs to be without credit. I believe the original icons are from Icons8.

TheZoker commented 7 months ago

Alright so this should be the car file: https://icons8.de/icon/set/car/material-rounded

And this would be the camper: https://icons8.de/icon/set/camper/material-rounded

Would that work for you?

tananaev commented 7 months ago

I don't think those are links to specific image.

TheZoker commented 7 months ago

Ah sorry, here is the correct link: https://icons8.de/icon/93858/wohnwagen-campingplatz

https://icons8.de/icon/85104/auto

tananaev commented 7 months ago

Yeah, looks good to me.

TheZoker commented 7 months ago

Here is the new preview:

image

Next to the camper I also added a caravan.

tananaev commented 7 months ago

Wait. Are we adding two icons now? I think that's a bit of overkill.

TheZoker commented 7 months ago

A friend that also uses the software for his caravan/trailer asked me if I can add this icon as well. But I can also remove it again

tananaev commented 7 months ago

I think one icon is enough.

TheZoker commented 7 months ago

Done, second icon is removed again

tananaev commented 7 months ago

Merged, thanks.