search

tracehubpm / code-review-action

Quality of Code Review Checker, plugin it as GitHub Action
MIT License
7 stars 2 forks source link

simulation tests are constantly failing #108

Open h1alexbel opened 6 months ago

h1alexbel commented 6 months ago

Our integration tests are flaky, mostly because of timing and delays from GitHub API. Let's fix them

h1alexbel commented 6 months ago 
13:20:38.639 [main] INFO com.jcabi.http.request.BaseRequest -- #fetch(GET api.github.com /rate_limit): [200 OK] in 158ms
13:20:38.640 [main] INFO git.tracehub.codereview.action.github.GhIdentity -- Connecting to GitHub...
13:20:38.640 [main] INFO git.tracehub.codereview.action.github.GhIdentity -- GitHub object instantiated
13:20:38.858 [main] INFO com.jcabi.http.request.BaseRequest -- #fetch(GET api.github.com /user): [200 OK] in 217ms
13:20:38.858 [main] INFO git.tracehub.codereview.action.github.GhIdentity -- GitHub connected as @tracehubgit
13:20:39.225 [main] INFO com.jcabi.http.request.BaseRequest -- #fetch(GET api.github.com /repos/h1alexbel/test/pulls/311/reviews/1971184892/comments): [200 OK] in 366ms
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.823 s - in it.JsonCommentsITCase
[INFO] 
[INFO] Results:
[INFO] 
Error:  Errors: 
Error:    AnalysisRoutineITCase.analyzesCodeReview:69 » IndexOutOfBounds Index: 0, Size: 0
HlibYasieniev commented 6 months ago

@h1alexbel can I take this one?

h1alexbel commented 6 months ago

@YasenevGleb sure, go ahead!

HlibYasieniev commented 6 months ago

@h1alexbel created a pull request, please take a look:) https://github.com/tracehubpm/code-review-action/pull/122

h1alexbel commented 6 months ago

@YasenevGleb nice, reviewed. BTW, you can link issues you work on in the pull requests