tracehubpm / code-review-action

Quality of Code Review Checker, plugin it as GitHub Action
MIT License
7 stars 2 forks source link

redundant variable #45

Closed l3r8yJ closed 8 months ago

l3r8yJ commented 8 months ago

title used only in one place and can be inlined

https://github.com/tracehubpm/code-review-action/blob/dbd3f5684d3ba0e60236fc1dac71b0c3ffc24750/src/main/java/git/tracehub/codereview/action/Entry.java#L88-L94

to

 Logger.info( 
     Entry.class, 
     "pull request found: #%s '%s'", 
     pull.number(), 
     pull.title()
 ); 
h1alexbel commented 8 months ago

@l3r8yJ thanks for the report. For now, title is redundant variable. But in future we plan to pass this variable in prompt. So it won't be redundant. Make sense?

l3r8yJ commented 8 months ago

@h1alexbel sure