tracehubpm / pmo

Project registry, facilities and its home
MIT License
4 stars 0 forks source link

Secrets API #48

Closed dukris closed 9 months ago

dukris commented 9 months ago

@h1alexbel take a look, please Closes #44


PR-Codex overview

This PR updates package names, adds secret-related functionality, and improves exception handling.

Detailed summary

The following files were skipped due to too many changes: src/main/java/git/tracehub/pmo/secret/Secret.java, src/main/java/git/tracehub/pmo/controller/request/SecretFromReq.java, src/main/java/git/tracehub/pmo/secret/Secrets.java, src/main/java/git/tracehub/pmo/secret/SecretOf.java, src/main/java/git/tracehub/pmo/exception/Logged.java, src/main/java/git/tracehub/pmo/exception/RestError.java, src/test/java/git/tracehub/pmo/secret/MockSecret.java, src/test/java/git/tracehub/pmo/controller/request/SecretFromReqTest.java, src/test/java/git/tracehub/pmo/exception/RestErrorTest.java, src/main/java/git/tracehub/pmo/secret/UniqueSecrets.java, src/test/java/git/tracehub/pmo/exception/LoggedTest.java, src/test/java/git/tracehub/pmo/secret/SecretOfTest.java, src/main/java/git/tracehub/pmo/secret/DefaultSecrets.java, src/main/java/git/tracehub/pmo/controller/SecretController.java, src/test/java/it/database/DefaultSecretsIT.java, src/main/java/git/tracehub/pmo/controller/AdviceController.java, src/test/java/git/tracehub/pmo/secret/UniqueSecretsTest.java, src/test/java/it/web/RetrieveSecretByKeyITCase.java, src/test/java/git/tracehub/pmo/controller/SecretControllerTest.java, src/test/java/it/web/CreateSecretITCase.java, src/test/java/git/tracehub/pmo/secret/DefaultSecretsTest.java

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

codecov[bot] commented 9 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (cc0964d) 79.18% compared to head (786aafb) 82.00%.

Files Patch % Lines
.../git/tracehub/pmo/controller/AdviceController.java 33.33% 12 Missing :warning:
...n/java/git/tracehub/pmo/secret/DefaultSecrets.java 96.55% 1 Missing :warning:
src/main/java/git/tracehub/pmo/secret/Secret.java 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #48 +/- ## ============================================ + Coverage 79.18% 82.00% +2.81% - Complexity 104 134 +30 ============================================ Files 34 44 +10 Lines 370 439 +69 Branches 7 8 +1 ============================================ + Hits 293 360 +67 - Misses 73 74 +1 - Partials 4 5 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

h1alexbel commented 9 months ago

@rultor merge

rultor commented 9 months ago

@rultor merge

@h1alexbel Thanks for your request; @hizmailovich please confirm this.

dukris commented 9 months ago

@rultor merge

rultor commented 9 months ago

@rultor merge

@hizmailovich OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 9 months ago

@rultor merge

@hizmailovich Done! FYI, the full log is here (took me 3min)