Open antimora opened 2 weeks ago
@skewballfox, your input is appreciated. Currently this bug is blocking #1915. It seems to be work for mnist.onnx checked in onnx-inference example. I am not sure why this isn't working. The attached onnx works with #1989 PR fix, so you know.
rephrasing what I mentioned on discord. passed
is only updated on the original graph inputs here, Mainly because passed is only used for filtering graph inputs (graph outputs can be filtered if they exist as a node output). The copy of the input argument in the graph inputs is listed as passed.
we could probably remove passed altogether and instead have a separate passed_input: Vec<bool>
in graph data.
The initializer thing (the numbered variable) is weird, because we have arguments like that in some of the onnx test (I think I see a tensor named 13 in add or Gemm test when debugging frequently), but normally those names don't make it into the generated burn code
Attaching ONNX file and graph output. face-detector-bug.zip
Here is a part of the parsed graph:
Noticed that
passed
flag is not set to true for the first input.Also
name: "517"
fails because it's a not a proper rust identifier. This result in this error:It looks like it was removed. Not sure if this is accidentally or intentionally:
crates/burn-import/src/onnx/from_onnx.rs of https://github.com/tracel-ai/burn/pull/1857/files