search

tracel-ai / burn

Burn is a new comprehensive dynamic Deep Learning Framework built using Rust with extreme flexibility, compute efficiency and portability as its primary goals.
https://burn.dev
Apache License 2.0
8.86k stars 435 forks source link

Training plots are not clear #211

Closed antimora closed 1 year ago

antimora commented 1 year ago

Describe the bug

The plots are not clear and have too many dots.

To Reproduce Run training of examples/mnist

Expected behavior It would be if a different markers are used to plot.

Screenshots image

Desktop (please complete the following information):

[~]$ uname -a
Darwin MacBook-Pro.local 22.3.0 Darwin Kernel Version 22.3.0: 
Mon Jan 30 20:38:37 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T6000 arm64
[~]$
NicBonetto commented 1 year ago

Hey, I was browsing reddit and found this project when looking for a Rust project to contribute to. I would love to help out. Has this issue been resolved yet?

antimora commented 1 year ago

Hi @NicBonetto , welcome to the project.

This has not been resolved. Your contribution is highly appreciated.

I filed this ticket originally. I thought the training charts are not that clear and could be improved.

@nathanielsimard and I are here to review your changes or can talk on discord to ask for help.

nathanielsimard commented 1 year ago

@NicBonetto Don't be afraid to come talk on Discord about how you want to tackle the issue; we can help. :)

antimora commented 1 year ago

I think we should replace the textplot with termplot library because textplot is not updated anymore and uses nom version 1 which gives a warning when building burn.

NicBonetto commented 1 year ago

I've just started to play around with the examples, and may need some help with initial setup. Is this a good place to ask or should we move the discussions over to discord? (sorry in advanced if these are stupid questions).

antimora commented 1 year ago

I've just started to play around with the examples, and may need some help with initial setup. Is this a good place to ask or should we move the discussions over to discord? (sorry in advanced if these are stupid questions).

Please do not worry about asking questions. We are all learning here and often we are not sure either.

I would recommend to try discord for back and worth questions/answers. We are all on it and it's not busy over there.

But I would suggest you keep updating the ticket to have a record of the discussion and new findings. It will help others learn as well.

nathanielsimard commented 1 year ago

I think we should replace the current implementation with something like ratatui https://github.com/ratatui-org/ratatui. It would be better than the actual implementation and seems much more maintained, potentially avoiding security vulnerabilities.