tracel-ai / burn

Burn is a new comprehensive dynamic Deep Learning Framework built using Rust with extreme flexibility, compute efficiency and portability as its primary goals.
https://burn.dev
Apache License 2.0
8.45k stars 415 forks source link

`./run-checks.sh all` fails #2198

Open loganbnielsen opened 3 weeks ago

loganbnielsen commented 3 weeks ago

Describe the bug ./run-checks.sh all fails

To Reproduce

  1. checkout repo
  2. run ./run-checks.sh all
  3. observe failures

Expected behavior No failures

Screenshots

burn on  main via 🦀 v1.81.0-nightly 
❯ ./run-checks.sh all
    Finished `dev` profile [optimized] target(s) in 0.25s
     Running `target/debug/xtask run-checks all`
[2024-08-24T04:37:19Z INFO  xtask::utils::cargo] cargo install typos-cli --version 1.
16.5 --color=always

     Ignored package `typos-cli v1.16.5` is already installed, use --force to overrid
e
[2024-08-24T04:37:19Z INFO  xtask::runchecks] Running typos check 

[2024-08-24T04:37:19Z INFO  xtask::runchecks] Cargo: fmt
[2024-08-24T04:37:19Z INFO  xtask::utils::cargo] cargo fmt --check --all -- --color=a
lways

[2024-08-24T04:37:20Z INFO  xtask::utils::cargo] cargo clippy --color=always --all-ta
rgets -- -D warnings

    Checking burn v0.14.0 (/home/logan/Code/burn/crates/burn)
    Checking burn-core v0.14.0 (/home/logan/Code/burn/crates/burn-core)
    Checking backend-comparison v0.14.0 (/home/logan/Code/burn/backend-comparison)
    Checking guide v0.14.0 (/home/logan/Code/burn/examples/guide)
    Checking burn-import v0.14.0 (/home/logan/Code/burn/crates/burn-import)
    Checking text-classification v0.14.0 (/home/logan/Code/burn/examples/text-classif
ication)
    Checking onnx-inference v0.14.0 (/home/logan/Code/burn/examples/onnx-inference)
    Checking custom-wgpu-kernel v0.14.0 (/home/logan/Code/burn/examples/custom-wgpu-k
ernel)
    Checking text-generation v0.14.0 (/home/logan/Code/burn/examples/text-generation)
    Checking mnist v0.14.0 (/home/logan/Code/burn/examples/mnist)
    Checking custom-image-dataset v0.14.0 (/home/logan/Code/burn/examples/custom-imag
e-dataset)
    Checking burn-no-std-tests v0.14.0 (/home/logan/Code/burn/crates/burn-no-std-test
s)
    Checking custom-csv-dataset v0.14.0 (/home/logan/Code/burn/examples/custom-csv-da
taset)
error: struct `ModelNewFieldOrders` is never constructed
  --> crates/burn-core/tests/record_resilience.rs:45:16
   |
45 |     pub struct ModelNewFieldOrders<B: Backend> {
   |                ^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

error: struct `ModuleTensorConstInt` is never constructed
  --> crates/burn-core/tests/derive_module.rs:19:8
   |
19 | struct ModuleTensorConstInt<B: Backend> {
   |        ^^^^^^^^^^^^^^^^^^^^
   |
   = note: `-D dead-code` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(dead_code)]`

error: enum `ModuleEnumNested` is never used
  --> crates/burn-core/tests/derive_module.rs:48:6
   |
48 | enum ModuleEnumNested<B: Backend> {
   |      ^^^^^^^^^^^^^^^^

error: enum `ModuleEnumWithGenericModule` is never used
  --> crates/burn-core/tests/derive_module.rs:53:6
   |
53 | enum ModuleEnumWithGenericModule<B: Backend, M: Module<B>> {
   |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^

    Checking named-tensor v0.14.0 (/home/logan/Code/burn/examples/named-tensor)
error: could not compile `burn-core` (test "record_resilience") due to 1 previous err
or
warning: build failed, waiting for other jobs to finish...
error: could not compile `burn-core` (test "derive_module") due to 3 previous errors
error: 
   --> backend-comparison/src/burnbenchapp/auth.rs:159:42
    |
159 |     response.ok()?.json::<Tokens>().ok().map(|new_tokens| {
    |                                          ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/mas
ter/index.html#manual_inspect
    = note: `-D clippy::manual-inspect` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_inspect)]`
help: try
    |
159 ~     response.ok()?.json::<Tokens>().ok().inspect(|new_tokens| {
160 ~         println!("✅ Token refreshed!");
    |

error: could not compile `backend-comparison` (lib) due to 1 previous error

burn on  main via 🦀 v1.81.0-nightly took 5s 
❯ git status
On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean

burn on  main via 🦀 v1.81.0-nightly 
❯ git pull
Already up to date.

Desktop (please complete the following information):

laggui commented 2 weeks ago

Seems like a rust nightly issue. We don't test against nightly, but if you use stable there shouldn't be an issue.