search

tracer-x / TracerX

TracerX Symbolic Virtual Machine
https://tracer-x.github.io/
Other
31 stars 11 forks source link

Updates on new-wpinterpolant #391

Closed ArpitaDutta closed 10 months ago

ArpitaDutta commented 1 year ago

The base is the master branch (after merging) and recent commits are cherrypicked from new-wpinterpolant branch.

ArpitaDutta commented 10 months ago

Please also post your test results on this branch compared to master branch.

The comparison result with master-branch wp is here.

ArpitaDutta commented 10 months ago

Updated the file with master branch deletion interpolation result.

ArpitaDutta commented 10 months ago

There are differences in the number of covered blocks and icmps for programs that have hit the timeout.

rasoolmaghareh commented 10 months ago

There are differences in the number of covered blocks and icmps for programs that have hit the timeout.

The results are good. All cases that have differences are reaching timeout, or have a meaningful explanation on the difference.

I think we can proceed with merging this MR after addressing the comments on formatting and squashing the commits.

ArpitaDutta commented 10 months ago

I have made this commit c75c384 today to remove the comments and formatting the code using clang.

rasoolmaghareh commented 10 months ago

I have made this commit c75c384 today to remove the comments and formatting the code using clang.

clang formatting seems not have been done correctly in lib/Core/TxTree.cpp

ArpitaDutta commented 10 months ago

I have disabled the assertion violation-related commit (1d5f8d3). Now trying to correctly format the lib/Core/TxTree.cpp file.

ArpitaDutta commented 10 months ago

Tried to reformat the lib/Core/TxTree.cpp file. Please let me know if there is any change required.