tracer0tong / android-emulator

Yet another Docker container with Android SDK and Android emulator
Apache License 2.0
246 stars 95 forks source link

Reduce size and number of layers #12

Closed nightscape closed 8 years ago

nightscape commented 8 years ago

The best practices for Dockerfiles state that the number of layers should be minimized as long as it doesn't negatively influence maintainability (https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/). I aggregated the RUN statements a little and grouped them into mostly coherent blocks and tried to minimize the number of temporary files that make it into a layer of the incremental file system (as those will always be present in the layers and only be marked as deleted). I also only installed the SDK versions for which an emulator image is installed in order to reduce file size. The original image had about 9.5 GB and if you use devicemapper2 as storage engine there is a 10GB size limit which occasionally led to No disk space left errors.

tracer0tong commented 8 years ago

Hi @nightscape you have made a gerat job, have no time for layers and size optimization, because today I have moved little bit far from my mobile projects. Image was huge, I'm agree with you. I think I will update version number also.