search

tracer0tong / android-emulator

Yet another Docker container with Android SDK and Android emulator
Apache License 2.0
246 stars 95 forks source link

Remove SSH and Ant #15

Closed nightscape closed 8 years ago

nightscape commented 8 years ago

Hi again @tracer0tong,

this PR is just a proposal as I don't exactly know what requirements you have for the emulator. I removed the SSH stuff, because for me the ability to docker exec into the container is sufficient in most cases. Also, Ant is not per se required for an image that just hosts an Android emulator. Do you in a later step build something inside the android-emulator container?

In both cases, would it be an option to just inherit from this image and install Ant and SSH in the inherited image? That would make the android-emulator image itself smaller and more secure.

If you're Ok with removing Ant, but not SSH or the other way round, I can also create a PR that does just this.

Best Martin

tracer0tong commented 8 years ago

@nightscape I think Ant is an artifact from the past. I will remove it. About SSH, unfortunately I'm personally using SSH to connect to Android.

tracer0tong commented 8 years ago

@nightscape I've removed Ant and I want to keep SSH, because I know systems, which are using it.

nightscape commented 8 years ago

:+1: