tracer0tong / kafkalogrus

Modified version of Kafka hook for Logrus
Apache License 2.0
7 stars 10 forks source link

adding TLS support for connection #4

Closed sebito91 closed 6 years ago

sebito91 commented 6 years ago

Add support for *tls.Config during initial hook creation.

Although configuring Kafka with SSL is a major PITA, for some workplaces/installations having a secure connection is required. The sarama binary already accepts incoming TLS connections as part of the client config so this change simply gives the user the ability to pass in their specific credentials.

I'd like to add a test to the binary as well but this would require an SSL kafka endpoint. Ping me if you'd like me to add as part of this PR.

PS: Thanks for pulling this together, very useful tool!

tracer0tong commented 6 years ago

Thank you!