search

tracespace / gerber-to-svg

gerber-to-svg development moved to tracespace/tracespace
https://github.com/tracespace/tracespace
MIT License
81 stars 17 forks source link

move to chai with expect syntax #12

Closed mcous closed 9 years ago

mcous commented 9 years ago

Specifically, a change in how .eql works with arrays seems to be causing failures in edge cases like -0 compared to 0.

Short term fix: rewrite failing tests. Long term fix: move library to chai with expect syntax.

mcous commented 9 years ago

On further investigation, both should and chai call 0 not equal to -0 in deep comparisons. Might be easier to just eliminate -0 in the app. Frustrating, but whatever.

mcous commented 9 years ago

Failing tests were corrected, but I still want to eventually move this to Chai because it seems like a better supported assertion library.

mcous commented 9 years ago

Migrated everything to chai. Happily enough, this also fixed the few tests that were failing in IE9. Woo.