Throws exception on non-gerber files

tracespace / gerber-to-svg

gerber-to-svg development moved to tracespace/tracespace

https://github.com/tracespace/tracespace

MIT License

81 stars 20 forks source link

Throws exception on non-gerber files #22

Closed henrikekblad closed 8 years ago

henrikekblad commented 9 years ago

When running my test-files I got an exception when feeding the following files: https://github.com/mgebundy/LilyPad-SR/tree/master/gerber

[Error: Error at line 17 - Cannot read property 'flashed' of undefined] at module.exports (/Users/hek/git/nodebb-plugin-gerber3d/node_modules/gerber-to-svg/lib/gerber-to-svg.js:90:13)

mcous commented 8 years ago

Just kidding this is still a problem

mcous commented 8 years ago

As of 2.0.0 this particular file is not longer causing problems, so I'm going to close this issue again. This particular error was caused by an overly lenient regex in the drill file parser of gerber-parser. Will reopen or file new issues if this continues to be a problem.

henrikekblad commented 8 years ago

👍