search

tracespace / gerber-to-svg

gerber-to-svg development moved to tracespace/tracespace
https://github.com/tracespace/tracespace
MIT License
81 stars 20 forks source link

Fix/aperturerelax #39

Closed gadgetjunkie closed 6 years ago

gadgetjunkie commented 6 years ago

Made attempts to stroke a non-circular aperture a warning rather than an error. This was necessary to be compatible with badly behaved eda tools which generate gerbers that do not strictly adhere to the gerber standard, such as MultiSim and Utilboard.

kasbah commented 6 years ago

Bit confused about this one, these changes were made 2 years ago when this project was still using Coffeescript!? It's pretty much undergone a complete re-write since then!

You have also thrown in some changes for Debian packaging and changed the repo URL in package.json to point at your fork. :confused:

kasbah commented 6 years ago

Ah, looks like you meant to PR to the fork (https://github.com/MacroFab/gerber-to-svg/pull/1). Would be good to switch MacroFab over to the modernized gerber-to-svg and upstream fixes like this though. :smiling_imp:

gadgetjunkie commented 6 years ago

That is correct – momentary lack of brain function on my end ☺.

Actually, our mainstream gerber processing stuff is using the modernized gerber-to-svg and associated libraries . This pr was to fix an issue on a legacy converter process that will eventually go away, and is not worth the work of switch to the newer stuff.

Cheers,

Mike

From: Kaspar Emanuel notifications@github.com Reply-To: mcous/gerber-to-svg reply@reply.github.com Date: Monday, November 6, 2017 at 3:10 PM To: mcous/gerber-to-svg gerber-to-svg@noreply.github.com Cc: Mike Williams mike@ddsw.com, State change state_change@noreply.github.com Subject: Re: [mcous/gerber-to-svg] Fix/aperturerelax (#39)

Ah, looks like you meant to PR to the fork. Would be good to switch MacroFab over to the modernized gerber-to-svg and upstream fixes like this though. 😈

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mcous/gerber-to-svg/pull/39#issuecomment-342287830, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AMEKmj34xtdwTwMbTAQ1Tbz5AD3zi90Aks5sz3XbgaJpZM4QT3P-.