tracespace / gerber-to-svg

gerber-to-svg development moved to tracespace/tracespace
https://github.com/tracespace/tracespace
MIT License
81 stars 17 forks source link

Support tool definitions that are zero padded eg T01 #9

Closed TheunisKotze closed 9 years ago

TheunisKotze commented 9 years ago

Sometimes there are inconsistencies with how a tool is defined and used, eg defined T1 & used as T01. The spec says to regard these as the same

mcous commented 9 years ago

Damn, I could've sworn I had fixed this at some point. I must've done it for Gerbers and not drill files or something. I'm gonna figure out why the Travis build is failing and then work on getting this merged in.

TheunisKotze commented 9 years ago

Ah I only see it is failing now. There were 3 tests failing before I made any changes (at least I think so), and they are still failing, is it that? Let me know if I can help out. Thanks for the lib btw!

mcous commented 9 years ago

Failing tests were due to a should.js change. Those texts were fixed with 9f3b510.

This pull request was manually merged and closed with 08ac9e0. Thanks for getting this fixed up!