trachten
commented
4 years ago On May 28, 2020, at 5:56 PM, 5/28/20, Novak Boškov notifications@github.com wrote:
@novakboskov requested changes on this pull request.
It looks good. Just a couple of questions.
In tests/unit/CommSocketTest.cpp https://github.com/trachten/cpisync/pull/52#discussion_r432144832:
@@ -50,7 +50,7 @@ void CommSocketTest::SocketSendAndReceiveTest() { //If socketSendReceiveTest() has finished successfully then kill child and break out of the loop if(result == 0) { CPPUNIT_FAIL("Sockets did not establish a connection in time");
- kill(timer_pid, 0);
- // kill(timer_pid, 0); We let the parent process to gracefully finish? Can we delete this commented line?
I think that it's dead code right now, so I don't see why not delete it.
In tests/unit/CuckooSyncTest.cpp https://github.com/trachten/cpisync/pull/52#discussion_r432145900:
@@ -57,5 +57,8 @@ void CuckooSyncTest::setReconcileTest() { // together because the execution trace picks up ZZ_p::init() call // before it reaches syncTest helper function. ZZ_p::init(randZZ());
- CPPUNIT_ASSERT(syncTest(client, server, false, false, false, false, false));
OK. I will look through it more thoroughly. Just wondering, did this happen to you after I fixed Cuckoo::prng?
I think it was independent ... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trachten/cpisync/pull/52#pullrequestreview-420518971, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACM5LU5UZISSMV3AH7M75PLRT3M2FANCNFSM4NGK3MWQ.
Ari Trachtenberg, Boston University http://people.bu.edu/trachten mailto:trachten@bu.edu
Random quote of the day:
"A pious Jew is not one who worries about his fellow man's soul and his own stomach, but one who worries about his own soul and his fellow man's stomach." - Rabbi Israel Salanter
Some cleanup of code style and efficiency ... more to come later.