trachten / cpisync

A library for synchronizing remote data with minimum communication.
GNU General Public License v3.0
26 stars 11 forks source link

Cleanup #60

Closed trachten closed 4 years ago

trachten commented 4 years ago

Some more commits.

novakboskov commented 4 years ago

@trachten There are some compiler errors on your last commit here (869eccd).

Also, do you use any compiler flags other than what is specified in CmakeList.txt? Could you also share the compiler version you use with this project? I see you mention some compiler warnings in some of your commit messages and I'm just wondering if we use different compilers.

trachten commented 4 years ago

Strange …. I’m just using llvm on a mac. I’ve updated to fix the break (it compiles fine on my machines).

On Jun 11, 2020, at 6:21 PM, Novak Boškov notifications@github.com wrote:

@trachten https://github.com/trachten There are some compiler errors https://github.com/trachten/cpisync/runs/763207089 on your last commit here (869eccd https://github.com/trachten/cpisync/commit/869eccd5d671379f60b8da30d7c870331eefaae9).

Also, do you use any compiler flags other than what is specified in CmakeList.txt? Could you also share the compiler version you use with this project? I see you mention some compiler warnings in some of your commit messages and I'm just wondering if we use different compilers.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trachten/cpisync/pull/60#issuecomment-642960241, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACM5LU6LCDSA7I57IXF6YJ3RWFKF7ANCNFSM4N2ZFMZA.


Prof. Ari Trachtenberg ECE, Boston University trachten@bu.edu http://people.bu.edu/trachten

trachten commented 4 years ago

Great!

On Jun 11, 2020, at 11:11 PM, 6/11/20, Novak Boškov notifications@github.com wrote:

@novakboskov commented on this pull request.

In src/Syncs/Cuckoo.cpp https://github.com/trachten/cpisync/pull/60#discussion_r439183536:

         _commit_relocation_chain(relocStack);

itemsCount++; return true;

  • }
  • } catch (overflow_error ignored) {} I tried it very naively:

int main() { for (size_t ii=0; ii<4000; ii++) { Cuckoo c = Cuckoo(7, 4, 1024, 500); c.insert(DataObject(ZZ(Cuckoo::_rand(0, 1 << 12)))); } } And, well, Linux perf show both if and try-cache (with GCC -O3) spend about the same estimated number of cycles in insert. Plain time says the same.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trachten/cpisync/pull/60#discussion_r439183536, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACM5LU4RVV75I4IOECWIM33RWGMFJANCNFSM4N2ZFMZA.


Ari Trachtenberg, Boston University http://people.bu.edu/trachten mailto:trachten@bu.edu

Random quote of the day: 
A day without sunshine is like, night.