create createForkForTest as a replacement for syncTestForkHandle

trachten / cpisync

A library for synchronizing remote data with minimum communication.

GNU General Public License v3.0

26 stars 11 forks source link

create createForkForTest as a replacement for syncTestForkHandle #61

Closed arorashu closed 4 years ago

arorashu commented 4 years ago

Addresses Issue#48

Open Question: Apart from success message from client and server, what are the additional checks for reconciliation success? Some of hese checks are written in TestAuxiliary.h :: syncTestForkHandle. I have only implemented the success message checks. Should I add the other checks as well?

novakboskov commented 4 years ago

@arorashu Looks like IBLTSync test fails. Could you look at that first? Find this in CI's output:

IBLTSyncTest.cpp:63:Assertion
Test name: IBLTSyncTest::IBLTSyncMultisetReconcileTest
assertion failed
- Expression: syncTest(GenSyncClient, GenSyncServer, false, true, false, true, 
false)