Default TryMe with CPISync fails

trachten / cpisync

A library for synchronizing remote data with minimum communication.

GNU General Public License v3.0

26 stars 11 forks source link

Default TryMe with CPISync fails #74

Open arorashu opened 4 years ago

arorashu commented 4 years ago

Using the default TryMe.cpp with CPISync fails for me.

How to replicate

checkout branch try-me-status
In terminal1, run $ TryMe client CPISync
In terminal2, run $ TryMe server CPISync

Output sync failed on both terminals

Expected Output sync succeeded.

Why I believe it fails on this line, due to the currDiff == maxDiff condition. I am not sure why that is triggered, will have to look into this further.

This is probably also affecting PR#73

novakboskov commented 4 years ago

Look through the parameters of CPISync. There exist a few that you might be interested in tweaking: m_bar, epsilon, and bits.

arorashu commented 4 years ago

Thanks! The mBar value was set to pretty low (1). I changed it to a acceptable value (256) and it works

arorashu commented 4 years ago

Created PR#77 for this