tracits / rodant

New repository for the new data collection tool
MIT License
0 stars 2 forks source link

Record created with only UID, all other variables named <unset> #125

Closed tracits closed 4 years ago

tracits commented 4 years ago

For site 1824, there's one record in the exported .csv file that has auid 1369, but no other variables are set. Unsure how this could happen. (It does crash the import on the backend site since is interpreted as a string.)

When importing this dataset to rodant, the record can not be found by searching all fields for the uid.

KarnellSchultz commented 4 years ago

Hey - I tried to reach out about this in our slack.

I'm not sure if I follow how to reproduce the issue. Mind giving me some steps to replicate? Any relevant screenshots could be helpful too.

Thanks

KarnellSchultz commented 4 years ago

Think we can close this issue since we've not been able to replicate it.

tracits commented 4 years ago

So this happens when you just create a record, and then close it. Since we changed the output from "" to NULL in the csv exports however, it does not effect the import backend any more. Also, we chose this behaviour, that a record that is not completed and missing mandatory information is still saved, so, I think this behaviour should now be considered expected. Agreed?

martingerdin commented 4 years ago

The problem is that it’s not possible to find these records using the tool, so there’s no way to delete them (except by exporting the database, deleting the records, and then importing the database again). I suggest that we modify the behavior so that these empty records are not saved.

tracits commented 4 years ago

You can't search for them, because the uid is not searchable, you will however see them when you list all records, you will se records with no pid and errors only. Here you're able to delete them.

However, I agree that a more correct behaviour is that a record that has only been created and contains no data, should not be saved when you press "Close record".

martingerdin commented 4 years ago

Of course, you’re right. And I agree that an empty record should not be saved when the user clicks close record or close the tab. I suggest that we close this issue and open a new. What do you think?

tracits commented 4 years ago

Agreed! Doing it now!