search

tracits / rodant

New repository for the new data collection tool
MIT License
0 stars 2 forks source link

Order by Patient center ID does not work #72

Open tracits opened 4 years ago

tracits commented 4 years ago

When importing a dataset, and choosing to sort by Patient center ID (pid), due to some reason these are not in ascending/decending order.

martingerdin commented 4 years ago

I don't think we should hard code pid as a special case, the name of that variable may very well change. The strange thing here is that pid is already defined as quantitative in the codebook, so the second clause in if (sortField.type === 'quantitative' || sortField.name == 'pid') should not make any difference.

kebabskal commented 4 years ago

Ah, a bit of confusion here. 'pid' == patient id. 'center' is what we are looking for. So either set 'center' as a quantitative or add a special case. Another solution would be to have a 'sortAs': 'number' etc in codebook.