search

tracked-tools / tracked-built-ins

Tracked versions of JavaScript's built-in classes
MIT License
128 stars 24 forks source link

Move Array#fill to "write then read" methods so the template correctly updates #408

Closed locks closed 12 months ago

locks commented 1 year ago

I was using Array#fill to showcase how to use TrackedArray and the template was not updating accordingly.

acorncom commented 1 year ago

@locks might be worth adding a simple test so we don’t regress in the future?

ef4 commented 12 months ago

The test failures on newer ember versions are because we need some blueprint updates. Working on that here: https://github.com/tracked-tools/tracked-built-ins/pull/409

ef4 commented 12 months ago

If you rebase on master now tests should be passing.

SergeAstapov commented 12 months ago

@locks Thank you! This is now published as v3.3.0. cc @ef4

locks commented 12 months ago

Thank you for the quick turnaround!