fix personal daily API (too long to run it)

tracking-exposed / facebook

facebook.tracking.exposed - collaborative tool for algorithm investigation

https://facebook.tracking.exposed

GNU Affero General Public License v3.0

113 stars 39 forks source link

fix personal daily API (too long to run it) #142

Closed vecna closed 5 years ago

vecna commented 5 years ago

At the moment the personal daily API is taking too long. the issue is the hardcoded limit of 300 timelines per day is the wrong approach, I should use 'startTime' selection.

vecna commented 5 years ago

Fixed, but still three small issue to solve:

[x] If I go three days in the past, three full days, means I've also the one of today (a fourth)
[ ] If a day has not access, should I return a default 0 0 0 ? would this make the UX implementation simpler because there is not to check the condition ?
[x] Order is not happening in chronological order but in alphabetical order

vecna commented 5 years ago

notes:

three is the least amount of day it will look to returns
the current day is considered as part of the days
if a person do not made any access in a day, it is absent. I believe I should return an object anyway, full of zeros.

@privatemaker what do you think of this last point?

vecna commented 5 years ago

talked and solved!