17R3 - Zone testing - Githubissues

trackmastersteve / alienfx

AlienFX is a CLI and GUI utility to control the lighting effects of your Alienware computer.

GNU General Public License v3.0

288 stars 69 forks source link

17R3 - Zone testing #38

Closed vakaobr closed 3 years ago

vakaobr commented 6 years ago

1. Expected behavior.

Zones should act as stated on software

2. Actual behavior.

Major problems:

Right Speaker - Zone missing (LED remains OFF)
Touchpad - Zone missing (LED remains OFF)

Misplaced zones to that specific model:

Alien Head Zone - Points to wi-fi / caps-lock / num-lock LED's zone
Media Bar (maybe this zone on 17R3 should be named "external cover") - Points to Left Speaker zone
Right Speaker - Points to Alienware name below the display (I think that is the zone named Logo) zone
Touchpad - Points to HDD LED zone
Logo - Points to Alien Head zone
Left speaker - Points to External Display Cover lines

Improvements/suggestions:

Right keyboard - That zone should be named numerical keyboard
Middle right keyboard - That zone should be named right keyboard
Middle left keyboard - That zone should be named center keyboard

trackmastersteve commented 6 years ago

If you would like, you can make those edits to https://github.com/trackmastersteve/alienfx/blob/master/alienfx/core/controller_17r3.py and send me a Pull Request for review. Or, if you like, I can just make those changes myself.

trackmastersteve commented 6 years ago

I have updated these zone codes. Please let me know if they are right.

derco0n commented 6 years ago

@vakaobr Please try to use the new zonescanner to determine the correct zones for your device

Personally, i refuse your suggestions to rename the keyboard zones. You should consider, that not every device has a numericcal keyboard. AFAIK only the 17" devices have one...

vakaobr commented 6 years ago

Hello Dennis,

Thanks, I will test it tomorrow morning and let you know.

The suggestion to rename zones it’s to match that specifically to 17”/18” inch models only.

Regards,

Anderson

Enviado do meu iPhone

Em 10 de ago de 2018, à(s) 18:46, Dennis Marx notifications@github.com escreveu:

@vakaobr Please try to use the new zonescanner to determine the correct zones for your device

Personally, i refuse your suggestions to rename the keyboard zones. You should consider, that not every device has a numericcal keyboard. AFAIK only the 17" devices have one...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.