trackmastersteve / alienfx

AlienFX is a CLI and GUI utility to control the lighting effects of your Alienware computer.
GNU General Public License v3.0
285 stars 70 forks source link

Zone scanner never finished a single zone #85

Open JustCryen opened 3 years ago

JustCryen commented 3 years ago

1. Expected behavior.

After running sudo alienfx -z and testing for newer controller - Testing zones... Testing zone "0x0001" I'd assume it's supposed to move on, ask me "is anything blinking now? (y/n):" and try the next one.

2. Actual behavior.

Zone scanner hangs on - Testing zones... Testing zone "0x0001" After ctrl+c i'm asked "is anything blinking now? (y/n):" Then moves on. I assume it doesn't really work that way.

3. Steps to reproduce the problem.

sudo alienfx -z would you like to test a newer controller? y done

4. Specifications

5. My situation

I know M15R1 is not supported, I'm trying to bring support for it and maybe a few other models too.

In zonescanner.py I increased maxzone (I've heard that some newer models used some way larger zone addresses)

I also changed the way the zones are incremented.

My main issue is I can't rely on zonescanner to show me which zone is in fact tested. I think it just hangs until I interrupt which is clearly not how it's supposed to work.

I don't really know any other way of finding out the correct zone addresses so any help on that would be appreciated as well.

dedguy21 commented 3 years ago

Can confirm this same behavior in "Dell G5 SE 5505". Arch Linux OS.

SpicyRatSauce commented 3 years ago

Same Issue on Dell G7 7700 Manjaro 20.2games

AadityaRavindran commented 3 years ago

Same issue on Alienware m17R3. I did a little more digging and I found that it is stuck waiting for the controller to get ready. ie, alienfx/core/controller.py -> _wait_controller_ready function. It sends the packet - "BAD PACKET: [2, 6, 0, 0, 0, 0, 0, 0, 0]" and gets the response "GET_STATUS" (when passed through self.pkt_to_string(resp)). Actual response is "array('B', [2, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0])"

scorpionPeppers commented 3 years ago

I have am experiencing the same with a Dell G7 7500. I'd like to contribute a config. I get Found device "0x187c / 0x0550"

I see the print statements in zonescanner.py I think its stuck in "scanzone" try statement since I dont see the "Error while testing current zone... " or "Is anything blinking now?" until I ctrl+c

AadityaPatanjali 's reference is called by this?

piraeusstef commented 2 years ago

Same here M15 R5 Ryzen 5900 HX - I could not stand win more than 3 days. Output:

You are running alienfx under Python-Version: 3.10.1 (main, Dec 7 2021, 00:00:00) [GCC 11.2.1 20211203 (Red Hat 11.2.1-7)] Performing zonescan... Welcome. This will help you to scan for alienfx-controllers and their lighting zones. Found device "0x187c / 0x0550". would you like to test a newer controller? default=y note that choosing a wrong controller will result in packet-errors. in this case you might choose another one instead. (y/n):y