trackreco / mkFit

Vectorized, Parallelized Tracking
https://trackreco.github.io/
Apache License 2.0
17 stars 15 forks source link

add compatibility requirement for propagations to strip hits #348

Closed slava77 closed 2 years ago

slava77 commented 2 years ago

The following condition is applied on hit-prop residuals to make sure that the propagation points consistently within the length bounds of the strip

More detail:

This is a bit of a kludge until we get the proper geometry details. The CKF tracking has a similar requirement.

Validation using mkfit=all and compiled with AVX2:=1 USE_INTRINSICS:=-DMPT_SIZE=1

In the following, screenshots are for built tracks from the initialStep in the ttbar PU50 sample orange is the same as the latest physics performance in this PR (6787d91) and has a small improvement compared to black, which was shown during the Aug 27 meeting

image

There is a small reduction in the number of hits due to rejection of fake hits

image

The number of missing outer is a bit better

image

a comparison with CKF is available in http://uaf-10.t2.ucsd.edu/~slava77/figs/mic/mtv/ttbar50_CKF_mkFit-pr344-pr345-qCompat_md94a476_c5e29902 (here qCompat is as of the earlier version shown in black in the mkfit=all comparisons above).

slava77 commented 2 years ago

some time ago we talked about improving SelectHitIndices by making corrections to approximately estimate the propagated position with respect to the hit (φ, q). This PR is a post-propagation check of a similar kind in q. Hopefully this can be eventually moved/reimplemented in the earlier stage in SelectHitIndices and save a bit in the propagation cost.