Closed osschar closed 3 years ago
@osschar please also run on 10muvlowpt sample (this is available directly in the input options since https://github.com/trackreco/cmssw/pull/47 was merged on Sep 17)
are there any concerns to merge this? (just as a heads up check before doing it probably after the meeting within an hour)
are there any concerns to merge this? (just as a heads up check before doing it probably after the meeting within an hour)
is this taking precedence over #357 and #358?
i want to add pt cut (1.2) and forward_search check ... and only calculate dphi if all else is true. e might weant to disable it for some iterations, i don't know. there is the question if we should fiddle with delta_phi, now hardcoded to 11.5 deg.
is this taking precedence over #357 and #358?
I think that this is independent
I'll just rerun ttbar validation to make sure i didn't screw up something.
Comparing stop-loopers before / after adding of pT cut -- practically all eff/fakes for built-tracks flat. http://xrd-cache-1.t2.ucsd.edu/matevz/PKF/stop-loopers-1.vs.2/
Stops tracks when their dr/ds angle gets shallower than 0.2 rad (11.5 deg). Radius below which the stopping is not applied is 25cm. There is no pT cut, it does not seem to be needed, but could save us some atan2s if we apply it and the r_min cut first.
I don't know if tuning of dr/ds cut makes sense.
I suspect this will partially overlap with large-cluster cut in #358, esp. in barrel
MTV vs CKF and #355 (devel): http://xrd-cache-1.t2.ucsd.edu/matevz/PKF/stop-loopers MTV with #355 as ref: http://xrd-cache-1.t2.ucsd.edu/matevz/PKF/stop-loopers.vs.355