search

trackreco / mkFit

Vectorized, Parallelized Tracking
https://trackreco.github.io/
Apache License 2.0
17 stars 15 forks source link

Relax detached triplet filter #365

Closed mmasciov closed 2 years ago

mmasciov commented 2 years ago

PR description

Updated (WP of the) detachedTripletStep quality filter is aimed at improving "Built track" efficiency as much as possible, with ~ no increase in fake rate. No change is expected in other iterations.

It requires update of mkFit JSON files: trackreco/cmssw#55

PR validation (PR #365 + trackreco/cmssw#55):

Expectation described above is confirmed by MTV results collected below. --> PRs are ready to be merged (in absence of objections).

(1) NO change in mkFit-4iter: http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-4iter_PR365/

(2) Slight increase in efficiency up to "All tracks" for mkFit-7iter, due to increase in efficiency for detachedTripletStep: http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-7iter_PR365_all/

(3) When mkFit is enabled only in detachedTripletStep, improvement in efficiency up to "All tracks": http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-detachedTripletStep_PR365_all/

(4) When mkFit is enabled in 4-iter + detachedTripletStep, improvement in efficiency up to "All tracks": http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-4iter-plusDetachedTripletStep_PR365_all/

mmasciov commented 2 years ago

PR validation (PR #365 + trackreco/cmssw#55):

Updated (WP of the) detachedTripletStep quality filter is aimed at improving "Built track" efficiency as much as possible, with ~ no increase in fake rate. No change is expected in other iterations. This is confirmed by MTV results collected below. --> PRs are ready to be merged (in absence of objections).

(1) NO change in mkFit-4iter: http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-4iter_PR365/

(2) Slight increase in efficiency up to "All tracks" for mkFit-7iter, due to increase in efficiency for detachedTripletStep: http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-7iter_PR365_all/

(3) When mkFit is enabled only in detachedTripletStep, improvement in efficiency up to "All tracks": http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-detachedTripletStep_PR365_all/

(4) When mkFit is enabled in 4-iter + detachedTripletStep, improvement in efficiency up to "All tracks": http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/SVA_displacedIters/detachedTripletFilter/MTV_mkFit-4iter-plusDetachedTripletStep_PR365_all/