trackreco / mkFit

Vectorized, Parallelized Tracking
https://trackreco.github.io/
Apache License 2.0
17 stars 15 forks source link

Adding counting of layers with match to TrackCand #370

Closed leonardogiannini closed 2 years ago

leonardogiannini commented 2 years ago

Adding a function to track cand that counts once the layers if they are a mono+stereo pair and they both have a valid hit

Example of matching and counting reduction in the figure going from 5 to 3 layers. the hits are counte inwards and the stereo layer is the outer one

image

this counter should be tested in filters that we already are using

leonardogiannini commented 2 years ago

I added a counter of Layers in groups of pixel / stereo / mono (non stereo) I tried to avoid calling the function three times for the same loop, so the result is in the format - - __ (e.g. 05-02-01) I can change the format if necessary

mmasciov commented 2 years ago

I added a counter of Layers in groups of pixel / stereo / mono (non stereo) I tried to avoid calling the function three times for the same loop, so the result is in the format - - __ (e.g. 05-02-01) I can change the format if necessary

@leonardogiannini, if I understand correctly the sum of pix+mono+stereo equals nUniqueLayers, which is currently computed by a different function. Maybe it would be better to just have a single function that returns all layer counters? That is, a function that:

I guess this would limit the number of loops in case more counters are needed?

On the other hand, I believe it would be good to also have analogous counters for the number of hits: nPixelHits, nStripMonoHits, nStripStereoHits, and maybe nStripGluedHits (corresponding to nStripMatchedLayers)?

leonardogiannini commented 2 years ago

I tried to write a function that updates the values given as arguments, but I had a strange compilation error the object has cv-qualifiers that are not compatible with the member function "mkfit::TrackCand::nLayersByType"

for the hits I can write the function. the only doubt is what to do when we have 4 hits (2 doubles) in glued layers. It's very rare, but I saw this double overlap.