search

tractatus / wholebrain

R package for segmentation, registration and generating web-based brain atlases from microscope images
GNU General Public License v3.0
83 stars 42 forks source link

allow possibility to feed biggest contour calculated elsewhere #17

Closed matiasandina closed 5 years ago

matiasandina commented 5 years ago

I'm sorry, somewhere in the middle, my indentation changed and it looks like I'm making a lot of changes. Most of them are just a space, a comment that changes a line number or some other indentation.

I also suggested some modifications that in my opinion increase the readability of some parts using dplyr. I think this is personal and opinionated so feel free to disregard and delete comments if you don't feel the same.

The real PR

The lines that I mostly needed to add start here (line 698)

  # If no correspondance provided
  if (is.null(correspondance)) {
    # Try to look for pre-processed contour
    if(!is.null(filter$biggest)){
      contourInput <- filter$biggest
...
tractatus commented 5 years ago

@matiasandina hi could you call it something else than filter$biggest_ Maybe filter$contour?