search

tractorcow-farm / silverstripe-fluent

Multi-language translate module for Silverstripe, without having to manage separate site trees.
BSD 3-Clause "New" or "Revised" License
93 stars 111 forks source link

FluentSiteTreeExtensionTest::testUpdateCMSFields throwing false negatives in CWP 2.0 #420

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Context: SS 4.1.1, CWP 2.0.0-rc4, fluent 4.0.2, MySQL 5.6

While compiling the CWP 2.0 release the following test fails consistently:

There was 1 failure:

1) TractorCow\Fluent\Tests\Extension\FluentSiteTreeExtensionTest::testUpdateCMSFields
Failed asserting that null is not null.

/Users/robbieaverill/dev/releases/release-cwp_cwp-recipe-kitchen-sink-2.0.0-rc4/vendor/tractorcow/silverstripe-fluent/tests/php/Extension/FluentSiteTreeExtensionTest.php:174
/Users/robbieaverill/dev/releases/release-cwp_cwp-recipe-kitchen-sink-2.0.0-rc4/vendor/phpunit/phpunit/phpunit:52

I note that it's passing in isolation in this module's 4.0 branch.

Manual testing in the CMS proves the functionality under test is in fact working as expected:

image

robbieaverill commented 6 years ago

Hmmm - seems to have passed in Travis: https://travis-ci.org/creative-commoners/cwp-recipe-kitchen-sink/jobs/385036833