search

tractorcow-farm / silverstripe-fluent

Multi-language translate module for Silverstripe, without having to manage separate site trees.
BSD 3-Clause "New" or "Revised" License
93 stars 111 forks source link

Push source translations to Transifex #656

Open robbieaverill opened 4 years ago

robbieaverill commented 4 years ago

Hey @tractorcow, I'm happy to do this myself, but you mentioned doing something specific recently around Transifex. Would you mind pushing the English translations up for the 5.x branch?

robbieaverill commented 4 years ago

cc @tomaszpirc

tractorcow commented 4 years ago

I haven't run the transifex client in ages; I need to set this up.

tractorcow commented 4 years ago

Setup, playing around with it during lunch. :)

tractorcow commented 4 years ago

ok, all pushed. However a lot of the keys have been updated (ran textcollector) so strings in transifex will need updating.

t3hn0 commented 4 years ago

@tractorcow I'm afraid it's not over yet. At least these translations are missing:

TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Localisation "Localisation"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_clearFluent "Clear from all except '{title}'"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_copyFluent "Copy '{title}' to other locales"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_unpublishFluent "Unpublish (all locales)"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_archiveFluent "Unpublish and Archive (all locales)"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_publishFluent "Save & Publish (all locales)"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_deleteFluent "Delete (all locales)"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_hideFluent "Hide from '{title}'"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.Label_showFluent "Show in '{title}'"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.ShowNotice "Record '{title}' is now visible in {locale}"
TractorCow\Fluent\Extension\Traits\FluentAdminTrait.HideNotice "Record '{title}' is now hidden in {locale}"

Another problem with translation will be actions "Copy from" and "Copy to" under Localisation tab on pages. Strings are added in CSS :/

robbieaverill commented 4 years ago

Another problem with translation will be actions "Copy from" and "Copy to" under Localisation tab on pages. Strings are added in CSS :/

Should we open a new issue to tackle that?

tomaszpirc commented 4 years ago

@robbieaverill I've managed to translate all strings that were pushed to transifex, but please wait for the missing ones mentioned by @t3hn0 before updating.

tractorcow commented 4 years ago

Ah, I relied on auto-generation to build these files. :) I'll do a manual review later.

blueskies79 commented 4 years ago

Hi folks, Since upgrading to Fluent 5, I'm getting some Textcollector errors that I suspect might be related:

Whoops \ Exception \ ErrorException (E_USER_WARNING) Error concatenating localisation key /data/site/vendor/silverstripe/framework/src/i18n/TextCollection/i18nTextCollector.php line 677

The i18nTextCollector.php apparently doesn't like an empty $currentEntity, and if I check which part it's choking on, it appears to be $currentClass = TractorCow/Fluent/Extension/Traits and $token = [ [0] => 317, [1] => '.Localisation', [2] => 103 ]

Would this also be related to the missing translations mentioned above? It's a bit of an issue for us at the moment, because it breaks the whole textcollector task. So if I can help somehow, please let me know!

tractorcow commented 4 years ago

My text collector throws so many errors, I have had to manually ignore most of them haha. I'll make a point to check though. :)

baukezwaan commented 1 year ago

@tractorcow sorry for bumping this old one... but would it possible to reload the translations from Transiflex sometime again?