search

tractorcow-farm / silverstripe-fluent

Multi-language translate module for Silverstripe, without having to manage separate site trees.
BSD 3-Clause "New" or "Revised" License
91 stars 110 forks source link

skip empty 'where' clauses for SS4 #799

Closed mikey-harveycameron closed 1 year ago

mikey-harveycameron commented 1 year ago

skip empty 'where' clauses. just trying to make this available for SS4.

tractorcow commented 1 year ago

Do you know when this value is ever blank? Is there another error that we are ignoring in this case? further upstream? My worry is that there's a condition we are handling wrong, and just ignoring it instead.

tractorcow commented 1 year ago

So this could occur if you had a condition like

$query->where(['' => 3]); // Not a valid condition, but is accepted anyway
tractorcow commented 1 year ago

No harm in the merge, but it'd be good to track down the cause please if you can add some more context in your own time. :)

mikey-harveycameron commented 1 year ago

Could you update this branch with a new tag or something please, so that composer update can reach it... maybe like 6.0.1? (Not quite sure how this works, my apologies.)

mikey-harveycameron commented 1 year ago

FYI I was able to target it with composer using "6.x-dev"