tractorcow-farm / silverstripe-fluent

Multi-language translate module for Silverstripe, without having to manage separate site trees.
BSD 3-Clause "New" or "Revised" License
91 stars 109 forks source link

Branching for CMS 6 #826

Closed maxime-rainville closed 6 months ago

maxime-rainville commented 6 months ago

We're looking at starting development for CMS 6 and we've noticed the branching strategy for Fluent is a out of sync with the one we use in Silverstripe CMS core module.

Proposed changes

  1. Merged master back in 7.
  2. Make 7 the default branch.
  3. Retarget any PRs directed at master to 7.
  4. Delete master branch.
  5. Fork an 8 branch from 7 and set it up for CMS 6 development.
maxime-rainville commented 6 months ago

@tractorcow @mfendeksilverstripe I got enough permissions to do all the proposed changes ... except 2.

Assuming you don't have any objection or question, could one of you update the default branch to 7. I can work with the CMS Squad to get the other 4 points done.

mfendeksilverstripe commented 6 months ago

hey @maxime-rainville I don't seem to have access for this either T_T

tractorcow commented 6 months ago

I guess it makes sense, since you don't need to have an alias, it reduces some overhead. I don't mind making this change, but please continue to check in with me if you want to make any convention changes. I'll action this now.

tractorcow commented 6 months ago

I've forked 8 but left default at 7. Does this suit, or should 8 be default now?

maxime-rainville commented 6 months ago

8 won't be tagged until we release CMS 6 next year. Keeping 7 as the default branch for now is the best course of action.

I'll get the team to set up the 8 for CMS 6 development.

Thanks for your help, Damian! :pray:

maxime-rainville commented 6 months ago

@emteknetnz has addressed the outstanding points here.