ENH Add ability to ignore missing fields

lekoala commented 5 months ago

Description

SHOW FULL FIELDS are costly queries. Maybe it's not necessary to do this on every request

Using debugbar, you can check the queries With this new feature, this prevents all queries: SHOW FULL FIELDS IN xxx

[ ] The target branch is correct
- See picking the right version
[ ] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[ ] The commit messages follow our commit message guidelines
[ ] The PR follows our contribution guidelines
[ ] Code changes follow our coding conventions
[ ] This change is covered with tests (or tests aren't necessary for this change)
[ ] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[ ] CI is green

tractorcow commented 5 months ago

The fix I've proposed at https://github.com/tractorcow-farm/silverstripe-fluent/pull/831 is better since it precisely enables the check only when necessary, rather than relying on the site owner to manually enable it.

tractorcow commented 5 months ago

@lekoala can you let me know if you are happy for me to merge my fix over yours?

lekoala commented 5 months ago

@tractorcow yes please do :-) your approach is better

tractorcow commented 5 months ago